Repository navigation
feat(ws): send graceful close frame to WebSocket clients on server shutdown (#347) - #536
Open
sparkysolutions10-pixel wants to merge 1 commit into
Conversation
sparkysolutions10-pixel
force-pushed
the
feat/ws-graceful-close-frame-347
branch
from
October 19, 2026 20:17
43f3d62 to
a55079b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #347
Summary of Changes
FanOutManager.destroy()by sending active WebSocket clients a clean close frame with code1001("Server shutting down") instead of abrupt TCP drop.flushWindowMs) allowing in-flight price updates to drain cleanly before terminating connections.destroy()is re-entrant and idempotent, preventing mid-fanout iteration exceptions.src/__tests__/fanout.test.ts.